e2e/vmss: align test path with volume path #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3u13r
requested review from
katexochen and
davidweisse
and removed request for
burgerdev
burgerdev
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1045 we changed where we mount the stateful volume from
/srv/stateto/state. Adjust the path where we create the test file accordingly. Since we don't ship any deployment that sets up this path anywhere, expect for the newly written example, there are no customers that can depend on it, apart from us. Generally, while our deployment is only an example, we should try to keep the path stable.Additionally, remove the unused
--skip-undeployflag from the e2e target in the justfile in order for the target to work again.To test:
just e2e volumestatefulset